Suggest mode: Auto-save subsystem (Phase 6)#78308
Open
adamsilverstein wants to merge 1 commit into
Open
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced May 14, 2026
Per-block debounced background save for Suggest mode. After a 1.5 s idle window, pending overlay edits persist as a note comment; subsequent edits on the same block update the existing note's meta rather than creating a new one, and a fully reverted overlay trashes the note. Saves on the same clientId run sequentially via a per-block promise queue, while different blocks run concurrently. Replaces the explicit SuggestionCommitBar toolbar button.
adamsilverstein
force-pushed
the
suggest-mode-autosave
branch
from
9978bd3 to
f9d22c7
Compare
adamsilverstein
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar and
spacedmonkey
as code owners
adamsilverstein
changed the base branch from
add-suggestion-mode
to
phase-5b-collab-sidebar-actions
adamsilverstein
added
[Type] Feature
adamsilverstein
added a commit
that referenced
this pull request
May 18, 2026
Three e2e tests asserted behavior not present on this branch; they were masked until the JS build break was fixed and the suite could run. editor-intent-switcher: the intent is session-scoped by design (see setEditorIntent / editorIntent reducer) - reload returns to Edit. Rewrite the reload test to assert that reset instead of expecting Suggest to persist, which the implementation deliberately refuses. suggestion-mode: 'auto-saves a content edit' and the heading-level capture test wait for an automatic debounced POST /wp/v2/comments. The debounced auto-save subsystem is Phase 6 (#78308), not in this stack's ancestry; here a suggestion is only persisted via the explicit commit-bar Submit button. Skip both with a tracking reference to #78308.
adamsilverstein
requested review from
Mamaduka and
t-hamano
and removed request for
ajitbohra,
fabiankaegy,
juanmaguitar and
spacedmonkey
adamsilverstein
added
Backport from WordPress Core
adamsilverstein
added
[Type] Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Follow-up to #77407 (Phase 5). Carves the auto-save subsystem out of Phase 5 so each PR concentrates on one concern — Phase 5 stays focused on REST permissions + PHP tests, and this PR owns the Google Docs–style background save.
Tracked in #73411.
What's in this PR
SuggestionAutoSave— invisible component that debounces overlay edits (1.5 s per block) and persists them asnotecomments with the_wp_suggestionmeta payload. Replaces the explicitSuggestionCommitBartoolbar button (restored on Phase 5 so the prior stack stays functional in isolation).clientIdchain sequentially so a slow network call can't race with a follow-up edit and produce duplicatePOSTs or out-of-order writes. Different blocks run concurrently.updateSuggestion/deleteSuggestionon the provider — once a comment id is linked, subsequent editsPUTthe same comment; a fully reverted overlay trashes the note. Includes a stale-link check via core-data so a peer-resolved comment doesn't get clobbered mid-session.commentIdandsyncedOpsKeyfields on overlay entries,SET_COMMENT_ID/SET_SYNCED_OPS_KEYreducer cases, and matchingsetCommentId/setSyncedOpsKeycallbacks on the context.Test plan
```bash
npm run test:unit -- packages/editor/src/components/suggestion-mode/
```
Stack
🗺️ PR Stack Navigation
_wp_suggestionmeta, provider, sidebar actions📋 Tracking issue: #73411